-
-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Reflect DynamicStruct field removal methods #22702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reflect DynamicStruct field removal methods #22702
Conversation
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
MrGVSV
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple nits but also I don't think we should include the other new methods on Struct (at least not part of this PR).
|
I split this PR between the Dynamic Struct removal methods and the Struct QOL #22708, to be merged after this one. |
alice-i-cecile
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the MSRV in this PR, and remove the lint warning. Once that's done, this LGTM.
Fixed: clippy::semicolon-if-nothing-returned
Co-authored-by: Gino Valente <49806985+MrGVSV@users.noreply.github.com>
23fb958 to
4315d52
Compare
bevy_reflect: Update MSRV from 1.85.0 to 1.87.0
Objective / Solution
Add methods for field removal on
DynamicStruct:Testing
4 New Tests, located in bevy_reflect/structs.rs:
dynamic_struct_remove_atdynamic_struct_remove_by_namedynamic_struct_remove_withdynamic_struct_remove_comboShowcase
Click to view showcase